Skip to content

Conversation

cryptodev-2s
Copy link
Contributor

@cryptodev-2s cryptodev-2s commented Oct 13, 2025

Explanation

This PR migrates AccountActivityService and BackendWebSocketService to the new @metamask/messenger message bus, as opposed to the one exported from @metamask/base-controller.

References

Checklist

  • I've updated the test suite for new or updated code as appropriate
  • I've updated documentation (JSDoc, Markdown, etc.) for new or updated code as appropriate
  • I've communicated my changes to consumers by updating changelogs for packages I've changed, highlighting breaking changes as necessary
  • I've prepared draft pull requests for clients and consumer packages to resolve any breaking changes

Note

Migrates AccountActivityService and BackendWebSocketService to the new @metamask/messenger, removing controller-messenger-specific exports and updating tests, dependencies, and configs.

  • Messaging migration:
    • Replace RestrictedMessenger with new Messenger from @metamask/messenger in AccountActivityService and BackendWebSocketService.
    • Update tests to create root messenger, delegate actions/events, and use synchronous publish.
  • Public API changes (BREAKING):
    • Remove exported controller-messenger-specific type aliases/constants (ACCOUNT_ACTIVITY_SERVICE_ALLOWED_*, *AllowedActions, *AllowedEvents) and stop re-exporting them in src/index.ts.
    • Update service messenger types to new Messenger generics.
  • Dependencies & config:
    • Add @metamask/messenger; remove @metamask/base-controller. Update tsconfig references and yarn.lock.
  • Docs:
    • CHANGELOG.md notes breaking changes and migration details.

Written by Cursor Bugbot for commit 1958e2f. This will update automatically on new commits. Configure here.

@cryptodev-2s cryptodev-2s changed the title refactor: migrate `{AccountActivity,BackendWebSocket}Service to @metam… refactor: migrate {AccountActivity,BackendWebSocket}Service to @metamask/messenger Oct 13, 2025
@cryptodev-2s cryptodev-2s self-assigned this Oct 13, 2025
@cryptodev-2s cryptodev-2s marked this pull request as ready for review October 13, 2025 17:55
@cryptodev-2s cryptodev-2s requested review from a team as code owners October 13, 2025 17:55
@cryptodev-2s cryptodev-2s force-pushed the cryptodev-2s/messenger/core-backend branch from 827f7f5 to 9a2a804 Compare October 13, 2025 17:55
@cryptodev-2s cryptodev-2s force-pushed the cryptodev-2s/messenger/core-backend branch from 9a2a804 to daec53e Compare October 13, 2025 17:55
@cryptodev-2s cryptodev-2s requested a review from Kriys94 October 13, 2025 17:58
Mrtenz
Mrtenz previously approved these changes Oct 14, 2025
Copy link
Contributor

@Kriys94 Kriys94 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM :)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants